Resolve boot issues in hybrid azure images during upgrades from RHEL 7 > 8 > 9. #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
This commit addresses the issue where the `/boot/grub2/grub.cfg` file is overwritten during the upgrade process by an old RHEL7 configuration leftover on the system, causing the system to fail to boot. The problem occurs on hybrid Azure images, which support both UEFI and Legacy systems and have both `grub-pc` and `grub-efi` packages installed. It is caused by one of the scriplets in `grub-efi` which overwrites the old configuration. If old configuration is detected, this actor regenerates the grub configuration using `grub2-mkconfig -o /boot/grub2/grub.cfg` after installing rpms to ensure the correct boot configuration is in place. The fix is applied specifically to Azure hybrid cloud systems. JIRA: RHEL-38255
dkubek
force-pushed
the
azure_hybrid_grubcfg_fix
branch
from
390e3e4 to
cc3fa6f
Compare
dkubek
force-pushed
the
azure_hybrid_grubcfg_fix
branch
3 times, most recently
from
0e3bf53 to
838a95a
Compare
fernflower
reviewed
Aug 27, 2024
repos/system_upgrade/common/actors/cloud/checkhybridimage/actor.py
Outdated
Show resolved
Hide resolved
dkubek
force-pushed
the
azure_hybrid_grubcfg_fix
branch
2 times, most recently
from
14a0302 to
807c270
Compare
MichalHe
reviewed
Sep 3, 2024
repos/system_upgrade/common/actors/cloud/checkgrubenvtofile/tests/test_checkgrubenvtofile.py
Outdated
Show resolved
Hide resolved
repos/system_upgrade/common/actors/cloud/checkhybridimage/libraries/checkhybridimage.py
Outdated
Show resolved
Hide resolved
repos/system_upgrade/common/actors/cloud/checkhybridimage/libraries/checkhybridimage.py
Outdated
Show resolved
Hide resolved
repos/system_upgrade/common/actors/cloud/checkhybridimage/tests/test_checkhybridimage.py
Outdated
Show resolved
Hide resolved
...m_upgrade/el8toel9/actors/cloud/checkvalidgrubcfghybrid/libraries/checkvalidgrubcfghybrid.py
Outdated
Show resolved
Hide resolved
...m_upgrade/el8toel9/actors/cloud/checkvalidgrubcfghybrid/libraries/checkvalidgrubcfghybrid.py
Outdated
Show resolved
Hide resolved
pirat89
reviewed
Sep 5, 2024
repos/system_upgrade/common/actors/cloud/checkgrubenvtofile/libraries/checkgrubenvtofile.py
Outdated
Show resolved
Hide resolved
pirat89
reviewed
Sep 5, 2024
repos/system_upgrade/common/actors/cloud/checkhybridimage/libraries/checkhybridimage.py
Outdated
Show resolved
Hide resolved
pirat89
reviewed
Sep 5, 2024
repos/system_upgrade/common/actors/cloud/checkhybridimage/actor.py
Outdated
Show resolved
Hide resolved
pirat89
reviewed
Sep 5, 2024
repos/system_upgrade/common/actors/cloud/checkgrubenvtofile/libraries/checkgrubenvtofile.py
Outdated
Show resolved
Hide resolved
Previosly detection of Azure hybrid image was tightly coupled with process of converting grubenv symlink to a regular file. Since there exists other issues relating to hybrid images it is worth to separate these two concepts. This commit modifies the ScanHybridImage actor so that it produces a message whel WALinuxAgent is detected or we are booted in bios and ESP partition is mounted and we are running on Hyper-V (sign of a hybrid image). New CheckGrubenvToFile actor is responsible for detection of grubenv symlink on hybrid images and tasks ConvertGrubenvToFile that is later responsible for the actual conversion.
dkubek
force-pushed
the
azure_hybrid_grubcfg_fix
branch
from
807c270 to
39d83e3
Compare
pirat89
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes
Restructure hybrid image detection
Previosly detection of Azure hybrid image was tightly coupled with process of converting grubenv symlink to a regular file. Since there exists other issues relating to hybrid images it is worth to separate these two concepts.
This commit modifies the
CheckHybridImageactor so that it produces a message whenWALinuxAgentis detectedNew
CheckGrubenvToFileactor is responsible for detection of grubenv symlink on hybrid images and tasksConvertGrubenvToFileto be later responsible for the actual conversion during the upgrade.Check potential boot failures in Azure Gen1 VMs due to invalid grubcfg
This change addresses the issue where the
/boot/grub2/grub.cfgfile is overwritten during the upgrade process by an old RHEL7 configuration leftover on the system, causing the system to fail to boot.The problem occurs on hybrid Azure images. The issue is caused by one of the scriplets in
grub-efiwhich overwrites during the upgrade current configuration in/boot/grub2/grub.cfgby an old configuration from/boot/efi/EFI/redhat/grub.cfg.The issue is detected and fixed specifically on Azure hybrid cloud systems.
If old configuration is detected, this actor regenerates the grub configuration using
grub2-mkconfig -o /boot/grub2/grub.cfgafter installing rpms to ensure the correct boot configuration is in place.Old configuration is detected by looking for a menuentry corresponding to a kernel from RHEL 7 which should not be present on RHEL 8 systems.
JIRA: RHEL-38255